Annotate granular update_issue tools as destructive#2471
Open
gokhanarkan wants to merge 1 commit into
Open
Conversation
Sets destructiveHint: true on the seven granular update_issue_* tools (title, body, assignees, labels, milestone, state, type) so the IFC client engine can apply egress policies before invocation. The unified issue_write tool is covered separately by #2470. Refs github/copilot-mcp-core#1623.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the granular issue update tool definitions to mark them as destructive operations, enabling IFC client-side egress policy enforcement for issue mutation actions.
Changes:
- Set
destructiveHint: truein the sharedissueUpdateToolhelper, covering the single-field granularupdate_issue_*tools. - Set
destructiveHint: truefor the standaloneupdate_issue_typetool definition. - Updated the corresponding tool schema snapshots to reflect the new destructive annotation.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/issues_granular.go | Marks granular issue update tools as destructive via tool annotations (including update_issue_type). |
| pkg/github/toolsnaps/update_issue_type.snap | Updates snapshot to show destructiveHint: true. |
| pkg/github/toolsnaps/update_issue_title.snap | Updates snapshot to show destructiveHint: true. |
| pkg/github/toolsnaps/update_issue_state.snap | Updates snapshot to show destructiveHint: true. |
| pkg/github/toolsnaps/update_issue_milestone.snap | Updates snapshot to show destructiveHint: true. |
| pkg/github/toolsnaps/update_issue_labels.snap | Updates snapshot to show destructiveHint: true. |
| pkg/github/toolsnaps/update_issue_body.snap | Updates snapshot to show destructiveHint: true. |
| pkg/github/toolsnaps/update_issue_assignees.snap | Updates snapshot to show destructiveHint: true. |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
destructiveHint: trueon the seven granularupdate_issue_*tools (title, body, assignees, labels, milestone, state, type) so the IFC client engine can apply egress policies. The unifiedissue_writetool is covered by #2470. Third of four egress annotations from github/copilot-mcp-core#1623.