Annotate create_issue and issue_write as destructive#2470
Open
gokhanarkan wants to merge 2 commits into
Open
Conversation
Sets destructiveHint: true on the granular create_issue tool and the unified issue_write tool so the IFC client engine can apply egress policies before invocation, regardless of which surface the client uses. Refs github/copilot-mcp-core#1623.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates MCP tool annotations so both the unified issue_write tool and the granular create_issue tool are marked as destructive, enabling the IFC client engine to consistently apply egress policies across tool surfaces.
Changes:
- Set
destructiveHint: truefor the unifiedissue_writetool annotations. - Set
destructiveHint: truefor the granularcreate_issuetool annotations. - Updated tool schema snapshots and added a unit test assertion to verify
issue_writeexposesDestructiveHint.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/issues.go | Marks issue_write as destructive via tool annotations. |
| pkg/github/issues_test.go | Asserts issue_write includes DestructiveHint. |
| pkg/github/issues_granular.go | Marks create_issue as destructive via tool annotations. |
| pkg/github/toolsnaps/issue_write.snap | Updates snapshot to include destructiveHint: true. |
| pkg/github/toolsnaps/create_issue.snap | Updates snapshot to include destructiveHint: true. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 2
…t_IssueWrite_Create Addresses Copilot feedback on #2470. The test exercises IssueWrite, so its name now matches the tool under test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
destructiveHint: trueon the granularcreate_issuetool and the unifiedissue_writetool so the IFC client engine can apply egress policies regardless of which surface the client uses. Second of four egress annotations from github/copilot-mcp-core#1623.