ROX-33248: deprecate helm/manifest install endpoints#20583
Open
porridge wants to merge 1 commit into
Open
Conversation
Mark gRPC endpoints related to helm/manifest-based installation as deprecated in proto files, since operator-based installation with CRS is now the recommended approach. Deprecated endpoints: - ClusterInitService.GetCAConfig (returns helm_values_bundle) - SensorUpgradeService (all 4 RPCs: GetSensorUpgradeConfig, UpdateSensorUpgradeConfig, TriggerSensorUpgrade, TriggerSensorCertRotation) - ClustersService.PostCluster and PutCluster - DeploymentFormat enum (KUBECTL, HELM, HELM_VALUES) REST endpoints noted as deprecated in CHANGELOG but not changed in this commit: /api/extensions/clusters/zip, /api/extensions/clusters/helm-config.yaml, /api/extensions/helm-charts/ Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
porridge
changed the title
Contributor
🚀 Build Images ReadyImages are ready for commit a07df8e. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-970-ga07df8ea37 |
|
@porridge: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecated gRPC endpoints:
ClusterInitService.GetCAConfig— returnshelm_values_bundlefor helm-based setupSensorUpgradeService(all RPCs) —GetSensorUpgradeConfig,UpdateSensorUpgradeConfig,TriggerSensorUpgrade,TriggerSensorCertRotation; the operator handles upgrades and cert rotationClustersService.PostClusterandPutCluster— used byroxctl sensor generateto registerclusters; with operator, clusters auto-register via CRS
DeploymentFormatenum (KUBECTL,HELM,HELM_VALUES)REST endpoints noted as deprecated in CHANGELOG (no code changes in this PR):
/api/extensions/clusters/zip/api/extensions/clusters/helm-config.yaml/api/extensions/helm-charts/User-facing documentation
Testing and quality
Automated testing
No test changes needed: this is a proto annotation-only change that adds
option deprecated = true;to existing endpoints. No behavior is changed, only deprecation metadata is added.
How I validated my change
make proto-generated-srcscompleted successfullymake roxvetpassed with no issuesgolangci-lintpassed with 0 issues// Deprecated: Do not use.annotations on all targeted methods