improvement(mothership): allow mship to send function execute timeout#4581
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR lets the mothership/copilot side pass an optional
Confidence Score: 3/5The core timeout feature is sound, but the rowIds description truncation in both generated schema files silently removes the run_column scoping capability from AI callers, which could cause unintended full-table column runs. The timeout conversion, default, and cap logic are correct and well-tested. The bundled rowIds description change drops the documented optional row-scope for run_column, meaning AI callers will always run run_column across the entire table rather than a requested subset. Both tool-catalog-v1.ts and tool-schemas-v1.ts need attention for the rowIds description truncation. Important Files Changed
Sequence DiagramsequenceDiagram
participant M as Mothership (mship)
participant E as executeTool (copilot executor)
participant B as buildAppToolParams
participant A as executeAppTool (tools/index)
participant F as function/execute handler
M->>E: "executeTool("function_execute", {code, timeout: 7}, {copilotToolExecution: true})"
E->>B: buildAppToolParams("function_execute", params, context)
Note over B: copilotToolExecution=true<br/>convert seconds to ms<br/>cap at DEFAULT_EXECUTION_TIMEOUT_MS<br/>timeout: 7000 ms
B-->>E: "{code, timeout: 7000, _context: {...}}"
E->>A: "executeAppTool("function_execute", {code, timeout: 7000}, false)"
A->>F: execute with timeout: 7000ms
F-->>A: result
A-->>E: "{success, output}"
E-->>M: ToolExecutionResult
Reviews (1): Last reviewed commit: "Improve mship fexecute" | Re-trigger Greptile |
Summary
Allows mship to send function execute timeout
Type of Change
Testing
Manual
Checklist