Harden LDAP config discovery during login#136
Merged
andrijapanicsb merged 1 commit intoMay 14, 2026
Merged
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stacks on top of apache#13152 and keeps the existing login-flow fix, while tightening a few edge cases found during review/testing.
Changes:
falseinstead of{}during login/logout initialization.listLdapConfigurationsis unavailable duringGetInfo, explicitly setSET_LDAPtofalseinstead of leaving the previous truthy placeholder.thenhandler.UpdateLdapConfigurationFlagon success so callers waiting on the dispatch do not hang.listLdapConfigurations, matching other optional discovery probes.Validation:
node --check ui/src/store/modules/user.jsnode --check ui/src/utils/request.jsgit diff --check