Skip to content

Harden LDAP config discovery during login#136

Merged
andrijapanicsb merged 1 commit into
shapeblue:skipRejectionLdapConfigfrom
andrijapanicsb:fix/list-ldap-config-login-pr13152
May 14, 2026
Merged

Harden LDAP config discovery during login#136
andrijapanicsb merged 1 commit into
shapeblue:skipRejectionLdapConfigfrom
andrijapanicsb:fix/list-ldap-config-login-pr13152

Conversation

@andrijapanicsb
Copy link
Copy Markdown

This stacks on top of apache#13152 and keeps the existing login-flow fix, while tightening a few edge cases found during review/testing.

Changes:

  • Reset LDAP state with boolean false instead of {} during login/logout initialization.
  • When listLdapConfigurations is unavailable during GetInfo, explicitly set SET_LDAP to false instead of leaving the previous truthy placeholder.
  • Guard LDAP count parsing so an ignored 401 response does not throw from the then handler.
  • Resolve UpdateLdapConfigurationFlag on success so callers waiting on the dispatch do not hang.
  • Suppress the generic 401 notification for listLdapConfigurations, matching other optional discovery probes.

Validation:

  • node --check ui/src/store/modules/user.js
  • node --check ui/src/utils/request.js
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant