Handle short-token edge case in BPE pair selection#1004
Merged
rasbt merged 2 commits intoApr 11, 2026
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Owner
|
Thanks for catching (and fixing) this issue @CLu1207 and @amit-chaubey I checked the other more complete BPE notebook and this one should be fine. Anyways, thanks for also adding the edge case tests. |
Contributor
Author
|
Thanks for the review and the merge, much appreciated! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1002
Summary
Noneinfind_freq_pairwhen fewer than 2 token IDs exist (or no pairs are found).train()from failing on short inputs by stopping gracefully.Why
Short inputs could produce an empty pair set, causing
max()/min()to fail beforetrain()can break onpair_id is None.Validation
find_freq_pair([]) -> Nonefind_freq_pair([42]) -> Nonetrain(""),train("H"), andtrain("He")run without error.