Skip to content

[3.15] gh-148821: Add more tests for invalid XML encodings (GH-149820) #149821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
May 14, 2026
+44 −4
Merged

[3.15] gh-148821: Add more tests for invalid XML encodings (GH-149820) #149821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 44 additions & 4 deletions Lib/test/test_pyexpat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def test_parse_again(self):
'mac-roman', 'mac-turkish',
'koi8-r', 'koi8-t', 'koi8-u', 'kz1048', 'ptcp154',
])
def test_supported_ecodings(self, encoding):
def test_supported_encodings(self, encoding):
out = self.Outputter()
parser = expat.ParserCreate()
self._hookup_callbacks(parser, out)
Expand All @@ -308,7 +308,7 @@ def test_supported_ecodings(self, encoding):
'UTF-8', 'utf-8', 'utf-16', 'utf-16le', 'utf-16be',
'koi8-u', 'cp1125', 'cp1251', 'iso8859-5', 'mac-cyrillic',
])
def test_supported_ecodings2(self, encoding):
def test_supported_encodings2(self, encoding):
out = self.Outputter()
parser = expat.ParserCreate()
self._hookup_callbacks(parser, out)
Expand All @@ -334,14 +334,54 @@ def test_supported_ecodings2(self, encoding):
"johab",
"Shift_JIS", "Shift_JIS-2004", "Shift_JISX0213",
])
def test_unsupportes_ecodings(self, encoding):
def test_unsupported_encodings(self, encoding):
parser = expat.ParserCreate()
data = (f'<?xml version="1.0" encoding="{encoding}"?>\n'
'<root></root>').encode(encoding)
with self.assertRaises(ValueError):
parser.Parse(data, True)

def test_unknown_ecoding(self):
parser = expat.ParserCreate()
data = (f'<?xml version="1.0" encoding="{encoding}"?>\n'
'<root></root>').encode()
with self.assertRaises(ValueError):
parser.Parse(data, True)

@support.subTests('encoding', [
'cp037', 'cp273', 'cp424', 'cp500', 'cp864', 'cp875',
'cp1026', 'cp1140',
'mac_arabic', 'mac_farsi',
])
def test_incompatible_encodings(self, encoding):
parser = expat.ParserCreate()
data = (f'<?xml version="1.0" encoding="{encoding}"?>\n'
'<root></root>').encode(encoding)
with self.assertRaises(expat.ExpatError):
parser.Parse(data, True)

parser = expat.ParserCreate()
data = (f'<?xml version="1.0" encoding="{encoding}"?>\n'
'<root></root>').encode()
with self.assertRaisesRegex(expat.ExpatError, 'unknown encoding'):
parser.Parse(data, True)

@support.subTests('encoding', [
'hex_codec', 'rot_13',
])
def test_non_text_encodings(self, encoding):
parser = expat.ParserCreate()
data = (f'<?xml version="1.0" encoding="{encoding}"?>\n'
'<root></root>').encode()
with self.assertRaises(LookupError):
parser.Parse(data, True)

def test_undefined_encoding(self):
parser = expat.ParserCreate()
data = b'<?xml version="1.0" encoding="undefined"?>\n<root></root>'
with self.assertRaises(UnicodeError):
parser.Parse(data, True)

def test_unknown_encoding(self):
parser = expat.ParserCreate()
data = b'<?xml version="1.0" encoding="xyz"?>\n<root></root>'
with self.assertRaises(LookupError):
Expand Down
Loading