gh-105895: Add match and case to help topics#132784
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I'm not sure if I should also commit the autogenerated |
|
This test case fails not due to unsorted keywords, but because class TestHelper(unittest.TestCase):
def test_keywords(self):
self.assertEqual(sorted(pydoc.Helper.keywords),
sorted(keyword.kwlist))I suggest splitting this into two separate cases: class TestHelper(unittest.TestCase):
def test_keywords_are_sorted(self):
self.assertEqual(
sorted(pydoc.Helper.keywords),
list(pydoc.Helper.keywords),
)
def test_keywords_in_grammar(self):
all_keywords = set(keyword.kwlist) | set(keyword.softkwlist)
for kw in pydoc.Helper.keywords:
self.assertIn(kw, all_keywords) |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
sobolevn
left a comment
There was a problem hiding this comment.
I checked out this PR and tried:
I think that you need to regen pydoc-topics with: make -C Doc pydoc-topics
It might take a while.
Also, add a NEWS entry (see #132784 (comment) about how to do that) and change the issue number :) I will update you PR title for you to match the original issue #132783
match and case to help topicsmatch and case to help topics
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
# Conflicts: # Lib/pydoc_data/topics.py
|
@sobolevn could you please look at the last changes? Is everything ok? |
sobolevn
left a comment
There was a problem hiding this comment.
LGTM, but I can't merge this PR. Since I am not an expert in pydoc and I need someone who knows how it actually works to verify :)
StanFromIreland
left a comment
There was a problem hiding this comment.
There are conflicts that need to be fixed.
There was a problem hiding this comment.
Please revert changes to this file, they will be automatically done before a release.
There was a problem hiding this comment.
Please move to "Library"
|
This PR is stale because it has been open for 30 days with no activity. |
helpseems to have no information onmatchorcase#105895📚 Documentation preview 📚: https://cpython-previews--132784.org.readthedocs.build/
helpseems to have no information onmatchorcase#105895