lib,fs: use process.emitWarning instead of internal print dep warning#8166
Closed
jasnell wants to merge 4 commits into
Closed
lib,fs: use process.emitWarning instead of internal print dep warning#8166jasnell wants to merge 4 commits into
jasnell wants to merge 4 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
lib, fs
Description of change
This removes uses of the the internal/util
printDeprecationMessage()API in favor ofusing
process.emitWarning(msg, 'DeprecationWarning'). This allows us to remove thegraceful-fs warning in
fsproviding at least a temporary relief of the logjam that isoccurring there.
The PR also adds a new lint rule that flags uses of
printDeprecationMessage()/cc @ChALkeR @thealphanerd @nodejs/ctc
This is an alternative to #6413. If this lands, We do not have to do the revert.