stream: validate broadcast writer writev chunks#63300
Open
trivikr wants to merge 1 commit into
Open
Conversation
Validate BroadcastWriter writev() and writevSync() inputs before converting chunks so non-array values throw ERR_INVALID_ARG_TYPE. Fixes: nodejs#63299 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
jasnell
approved these changes
May 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63300 +/- ##
==========================================
- Coverage 90.05% 90.04% -0.01%
==========================================
Files 714 714
Lines 225247 225253 +6
Branches 42578 42581 +3
==========================================
- Hits 202842 202830 -12
- Misses 14181 14220 +39
+ Partials 8224 8203 -21
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BroadcastWriter
writev()andwritevSync()input validation sonon-array
chunksvalues throwERR_INVALID_ARG_TYPEbefore reachingconvertChunks().Previously,
writer.writev('abc')treated the string as array-like and wroteabc, whilewriter.writev(42)resolved as an empty batch.Fixes: #63299
Assisted-by: openai:gpt-5.5