Skip to content

Refactor the format skills#35

Open
mingxwa wants to merge 3 commits into
ngcpp:mainfrom
mingxwa:user/mingxwa/refactor-format
Open

Refactor the format skills#35
mingxwa wants to merge 3 commits into
ngcpp:mainfrom
mingxwa:user/mingxwa/refactor-format

Conversation

@mingxwa
Copy link
Copy Markdown
Collaborator

@mingxwa mingxwa commented May 10, 2026

Changes

  • Added unit tests for pro::skills::fmt_format when Unicode support is disabled from fmt library to avoid regression.
  • Added <version> to proxy.h to avoid including <format> when the header exists but does not comply to the standard.
  • Simplified compiler flag management.
  • Use accessor (details::enabled_t) to identify whether std::format is enabled for a specific type with clean std::is_base_of_v, rather than relying on metaprogramming techniques like facade_traits::is_invocable, which is intrusive to proxy implementation.
  • Merged std::formatter and fmt::formatter implementation into one traits template.

No functional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant