fix: omit resource from OAuth refresh grants#2594
Closed
he-yufeng wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this as a duplicate of #2590. I missed the existing branch when I opened this newer version. #2590 is the better one to keep: it was opened first, has the same CI coverage green, and keeps the bare-domain resource normalization narrower by only removing Pydantic's synthetic root slash instead of stripping every trailing slash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resourcefrom refresh-token grants while keeping it on authorization-code token exchange when requiredget_resource_url()Closes #2578
To verify
.venv\Scripts\python.exe -m pytest tests\client\test_auth.py::TestProtectedResourceMetadata tests\client\test_auth.py::test_get_resource_url_omits_pydantic_root_slash tests\client\test_auth.py::test_get_resource_url_uses_canonical_when_prm_mismatches tests\client\test_auth.py::TestOAuthFallback::test_refresh_token_request -q --basetemp .tmp\pytest -p no:cacheprovider.venv\Scripts\python.exe -m ruff check src\mcp\client\auth\oauth2.py tests\client\test_auth.py.venv\Scripts\python.exe -m ruff format --check src\mcp\client\auth\oauth2.py tests\client\test_auth.py.venv\Scripts\python.exe -m py_compile src\mcp\client\auth\oauth2.py tests\client\test_auth.pygit diff --check