Skip to content

fix connection termination#5

Merged
bentsku merged 1 commit into
masterfrom
fix-termination
Oct 27, 2022
Merged

fix connection termination#5
bentsku merged 1 commit into
masterfrom
fix-termination

Conversation

@bentsku
Copy link
Copy Markdown

@bentsku bentsku commented Oct 25, 2022

While testing the proxy for a bug report, it came to light that we would always try to send a termination packet to Postgres when the proxied client would close the connection, even if it already sent it before. We now set a property if the client already sent a termination message, and won't send it again.

@bentsku bentsku requested a review from whummer October 25, 2022 14:02
Copy link
Copy Markdown
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @bentsku - definitely makes sense to make the _unregister_conn(..) method idempotent. 👍

@bentsku bentsku merged commit d698509 into master Oct 27, 2022
@bentsku bentsku deleted the fix-termination branch October 27, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants