fix(integration): clarify multi-install guidance#2549
Open
PascalThuet wants to merge 1 commit into
Open
Conversation
4ad3d1d to
1535f73
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies CLI guidance for specify integration install when an integration is already installed or when unsafe multi-install requires an explicit opt-in.
Changes:
- Updates already-installed messaging to suggest
useorupgradeinstead of uninstalling. - Separates replacement guidance from coexistence guidance for unsafe multi-install errors.
- Adds/updates integration subcommand tests to cover the new guidance text.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/__init__.py |
Refines integration install guidance messages without changing behavior. |
tests/integrations/test_integration_subcommand.py |
Adds assertions for default/non-default already-installed cases and unsafe multi-install guidance. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2498 and #2519.
Clarifies
specify integration installguidance when the requested integration is already installed or when installing alongside existing integrations requires an explicit unsafe multi-install opt-in.Changes
uninstall firstsuggestion with non-destructiveuse/upgradeguidance.specify integration switch <key>to replace the default integration.specify integration install <key> --forceto install alongside existing integrations anyway.Notes
This only changes CLI guidance text and tests. It does not change install, switch, or multi-install behavior.
Validation
Local:
uv run pytest tests/integrations/test_integration_subcommand.py -vgit diff --check origin/mainCI:
AI Disclosure
Used AI assistance to inspect the existing integration install flow, implement the scoped guidance update, add tests, and run local validation. The changes were reviewed before submission.