Remove unused Pages permissions and dead steps from test job#83
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code as per review comment
Remove unused Pages permissions and dead steps from test job
May 14, 2026
KittyChiu
requested review from
a team and
bot-digital-customer-success
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up the test job in the PR check workflow by removing permissions and steps that became dead code after the Pages deployment step was removed.
Changes:
- Drops
id-token: writeandpages: writepermissions from thetestjob. - Removes the
Setup Pagesstep (actions/configure-pages@v6). - Removes the
Upload Pages artifactstep (actions/upload-pages-artifact@v5).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr-check.yml | Removes unused Pages-related permissions and two dead workflow steps no longer needed by htmlproofer. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the
actions/deploy-pagesstep was removed, thetestjob retained permissions and steps that no longer serve any purpose.Changes
pages: writeandid-token: writefrom thetestjob — only needed for deploying to Pages.actions/configure-pages("Setup Pages") — no longer needed without a deployment target.actions/upload-pages-artifact("Upload Pages artifact") —htmlprooferreads from$SITE_DIRdirectly; nothing consumes the uploaded artifact.