Annotate add_issue_comment as destructive#2469
Open
gokhanarkan wants to merge 2 commits into
Open
Conversation
Sets destructiveHint: true on the add_issue_comment tool annotations so the IFC client engine can apply egress policies before invocation. Refs github/copilot-mcp-core#1623.
Contributor
There was a problem hiding this comment.
Pull request overview
Annotates the add_issue_comment MCP tool as destructive so IFC client engines can apply egress policies prior to invocation, aligning tool metadata with its side-effecting behavior.
Changes:
- Set
DestructiveHint: trueon theadd_issue_commenttool annotations. - Added/updated unit test assertions to validate the destructive annotation.
- Updated the
add_issue_commenttool schema snapshot to reflect the new annotation.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/issues.go | Marks add_issue_comment as destructive via tool annotations. |
| pkg/github/issues_test.go | Asserts DestructiveHint is present and set to true. |
| pkg/github/toolsnaps/add_issue_comment.snap | Updates toolsnap to include destructiveHint: true. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
destructiveHint: trueonadd_issue_commentso the IFC client engine can apply egress policies before invocation. First of four egress annotations from github/copilot-mcp-core#1623.