docs(instructions): never suggest pull_request_target over pull_request#30718
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f1d50a2f-53ce-44b6-8edf-a6a5fcf4876d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 7, 2026 01:52
View session
pelikhan
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Agentic Workflow authoring docs to add a clear security rule: don’t recommend pull_request_target as a substitute for pull_request, and align label-trigger guidance accordingly.
Changes:
- Added explicit trigger-selection guidance in workflow creation instructions to keep
pull_requestunlesspull_request_targetis explicitly required. - Added the same guidance to workflow frontmatter edit instructions.
- Updated syntax reference to use
pull_request(notpull_request_target) in labeled-trigger examples and cleaned up trailing whitespace.
Show a summary per file
| File | Description |
|---|---|
| .github/aw/update-agentic-workflow.md | Adds an explicit “don’t suggest pull_request_target” rule when editing workflow triggers. |
| .github/aw/syntax.md | Adjusts labeled-trigger guidance to reference pull_request and removes trailing whitespace. |
| .github/aw/create-agentic-workflow.md | Adds an explicit security rule for trigger selection during workflow creation. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_targetas a replacement forpull_requestpull_requestfor labeled-trigger examplesValidation
make build && make fmt && make agent-report-progressparallel_validation(Code Review: success, CodeQL: skipped as trivial docs-only change)