[FlightReply] Don't drop FormData entries in decodeReplyFromBusboy#36468
Open
unstubbable wants to merge 3 commits into
Open
[FlightReply] Don't drop FormData entries in decodeReplyFromBusboy#36468unstubbable wants to merge 3 commits into
decodeReplyFromBusboy#36468unstubbable wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
React Core Team
unstubbable
force-pushed
the
fix-form-data-regression
branch
from
350689b to
d94bedc
Compare
gnoff
reviewed
May 13, 2026
gnoff
reviewed
May 13, 2026
Collaborator
gnoff
left a comment
gnoff
left a comment
There was a problem hiding this comment.
could store queueFields on the file entry. always push to the top pendingFile.
Then you only flush when you get data an end even on value and you flush each file followed by it's queueFields until you hit the next pending file. splice the files array to eliminate flushed files and fields
unstubbable
force-pushed
the
fix-form-data-regression
branch
from
d94bedc to
393e3aa
Compare
Fixes a regression from facebook#36425 where referenced `FormData` entries can be dropped by `decodeReplyFromBusboy` when files are interleaved with text fields in the payload. `decodeReplyFromBusboy` queues text fields that arrive while a file is being streamed and flushes them after the last file's `'end'`, working around busboy emitting `'end'` deferred relative to subsequent `'field'` events. With multiple files interleaved with text, this loses the relative order of the affected text entries. The reorder was a long-standing but invisible issue — entries came back in the wrong order but were all present — until facebook#36425 tightened how referenced FormData entries are collected from the backing store to rely on them being contiguous. With that assumption violated, referenced FormDatas can now come back with some entries dropped. The pattern is most easily surfaced through `useActionState` actions that return the submitted `FormData` as part of their state. This replaces the tail-flush with a positionally-tagged buffer drained in arrival order. `flush()` walks from a monotonic index pointer, resolving text immediately and files once their `'end'` has fired, and holding later entries when the cursor lands on a still-streaming file. The backing FormData now matches the payload's order, restoring the contiguity assumption (and fixing the long-standing reorder as a side effect). The same change is applied to all five copies in `react-server-dom-{webpack,turbopack,parcel,esm,unbundled}`. Two new tests cover the multi-file interleave. fixes vercel/next.js#93822
unstubbable
force-pushed
the
fix-form-data-regression
branch
from
76b9503 to
5978b45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #36425 where referenced
FormDataentries can be dropped bydecodeReplyFromBusboywhen files are interleaved with text fields in the payload.decodeReplyFromBusboyqueues text fields that arrive while a file is being streamed and flushes them after the last file's'end', working around busboy emitting'end'deferred relative to subsequent'field'events. With multiple files interleaved with text, this loses the relative order of the affected text entries. The reorder was a long-standing but invisible issue — entries came back in the wrong order but were all present — until #36425 tightened how referenced FormData entries are collected from the backing store to rely on them being contiguous. With that assumption violated, referenced FormDatas can now come back with some entries dropped. The pattern is most easily surfaced throughuseActionStateactions that return the submittedFormDataas part of their state.This replaces the tail-flush with a positionally-tagged buffer drained in arrival order.
flush()walks from a monotonic index pointer, resolving text immediately and files once their'end'has fired, and holding later entries when the cursor lands on a still-streaming file. The backing FormData now matches the payload's order, restoring the contiguity assumption (and fixing the long-standing reorder as a side effect). The same change is applied to all five copies inreact-server-dom-{webpack,turbopack,parcel,esm,unbundled}. Two new tests cover the multi-file interleave.fixes vercel/next.js#93822