[compiler] Allow recursive useEffectEvent callbacks#36464
Open
yudin-s wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34888.
The mutation inference pass was treating recursive references to a function returned from
useEffectEventas a use-before-declaration of the hoisted context variable. This happened because the scan for hoisted context accesses did not distinguish the declaration's initializer from true prior accesses, and it also continued to consider references after theStoreContext Constinitialization as early reads.This tracks initialized hoisted context declarations while finding early accesses and treats self-references through a
useEffectEventinitializer as safe. The existing invalid setState-before-declaration case remains covered.How did you test this change?
corepack yarn prettier --check packages/babel-plugin-react-compiler/src/Inference/InferMutationAliasingEffects.ts packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/allow-recursive-useEffectEvent.tsxcorepack yarn buildfromcompiler/packages/babel-plugin-react-compilercorepack yarn snap:buildfromcompilernode ../snap/dist/main.js test --worker-threads false --pattern allow-recursive-useEffectEventshowed1 Tests, 1 Passed, 0 Failedbefore local snap runner shutdown errorFarm is ended, no more calls can be done to itnode ../snap/dist/main.js test --worker-threads false --pattern error.invalid-hoisting-setstateshowed1 Tests, 1 Passed, 0 Failedbefore the same local snap runner shutdown error