[proposal] Sharing code between Dev Container Features#209
Merged
Conversation
jkeech
reviewed
Mar 13, 2023
chrmarti
requested changes
Mar 14, 2023
bamurtaugh
reviewed
Mar 14, 2023
Member
bamurtaugh
left a comment
bamurtaugh
left a comment
There was a problem hiding this comment.
Thanks so much for putting this together! Very clear, and I think it's great to address this due to the motivations and feedback you mention. Only had very nit cleanup comments.
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
thereeroyz
approved these changes
Mar 18, 2023
4 tasks
chrmarti
requested changes
Mar 21, 2023
Member
Author
chrmarti
requested changes
Apr 4, 2023
chrmarti
approved these changes
Apr 18, 2023
This was referenced May 1, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #129