-
Notifications
You must be signed in to change notification settings - Fork 101
Fix hang on UTF-16 LE BOM file #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chrchr-github
wants to merge
11
commits into
cppcheck-opensource:master
Choose a base branch
from
chrchr-github:chr_utf16
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
14a44eb
Fix hang on UTF- 16 LE BOM file
chrchr-github 4cc9e60
Update simplecpp.cpp
chrchr-github b928752
Update simplecpp.cpp
chrchr-github bcb50ec
Update simplecpp.cpp [skip ci]
chrchr-github 9f371ac
Update integration_test.py
chrchr-github 47f267c
Update integration_test.py
chrchr-github ed1fef4
Update integration_test.py
chrchr-github ebe842f
Update simplecpp.cpp
chrchr-github b004fad
Update integration_test.py
chrchr-github 202f265
Update integration_test.py
chrchr-github dd90001
Merge branch 'cppcheck-opensource:master' into chr_utf16
chrchr-github File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate that we handle EOF. However, spontanously it does not seem optimal to return some abitrary ch value. It's implementation defined what value of EOF is right? If we would return 0xFF we at least know what the return value is. Or do we want to have the implementation defined return value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to return
EOFsince we are a custom layer on top ofgetc(). And since we use theEOFmacro it is not "arbitrary" but the one defined by the libc implementation.