Problem 234 project Euler

[archithadge]

No description provided.

[cclauss]

Please change the filename so that it ends in .py.

Also, please add a comment at the top of the file that links to the problem statement:
# https://projecteuler.net/problem=234

[eamanu]

Some pep8 revisions

[cclauss]

Or automate the process by running python/black.

[eamanu]

Or automate the process by running python/black.

+1

[eamanu]

I left a comments. But I think this could be merge :-)

[eamanu]

I think this else could be ignore. Because never will be go to else if return occur before. (Just a comment)

and temp=0 could be defined after the ifs. This way we could avoid use memory when is not necessary.

[archithadge]

Okay. Thank u for suggestions. Regards Archit H.

…

On Tue, 11 Jun 2019, 4:47 am Emmanuel Arias, ***@***.***> wrote: ***@***.**** approved this pull request. I left a comments. But I think this could be merge :-) ------------------------------ In project_euler/problem_234.py <#883 (comment)>: > @@ -0,0 +1,31 @@ +# https://projecteuler.net/problem=234 +def fib(a, b, n): + temp = 0 + if n==1: + return a + elif n==2: + return b + elif n==3: + return str(a)+str(b) + else: I think this else could be ignore. Because never will be go to else if return occur before. (Just a comment) and temp=0 could be defined after the ifs. This way we could avoid use memory when is not necessary. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#883?email_source=notifications&email_token=AK6GTHFCH7Q2SQ23HD73N53PZ3OHZA5CNFSM4HVRSQSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3DHVBY#pullrequestreview-247888519>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK6GTHE6VWF4JG6AKWQ6XO3PZ3OHZANCNFSM4HVRSQSA> .

[archithadge]

Are you going to merge it?

[eamanu]

Are you going to merge it?

You should wait for the commiters to merge it. I CC @poyea

[poyea]

Thank you for your pull request!🤩