Update CONTRIBUTING.md#1250
Merged
Merged
Conversation
cozek
approved these changes
Oct 2, 2019
cozek
approved these changes
Oct 2, 2019
cozek
approved these changes
Oct 2, 2019
Member
cozek
left a comment
cozek
left a comment
There was a problem hiding this comment.
Looks good. Much needed changes.
AnupKumarPanwar
approved these changes
Oct 2, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Update CONTRIBUTING.md * Update CONTRIBUTING.md * Add Python type hints and mypy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many Hacktoberfest contributors are not used to automated testing so these updates to CONTRIBUTING.md should help them to understand our standards and recomendations.
@cozek Thanks for your review.